refactor(transformer/class-properties): debug assert private_field_count is 0 at end of transform#10457
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 17, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Instrumentation Performance ReportMerging #10457 will not alter performanceComparing Summary
|
Member
Author
|
@Dunqing Oh dear! |
Dunqing
force-pushed
the
04-16-refactor_transformer_class-properties_debug_assert_private_field_count_is_0_at_end_of_transform
branch
from
ccc2df1 to
e68cb60
Compare
Dunqing
force-pushed
the
04-16-refactor_transformer_class-properties_debug_assert_private_field_count_is_0_at_end_of_transform
branch
from
e68cb60 to
51a8979
Compare
Dunqing
changed the base branch from
graphite-base/10457
to
04-17-fix_transformer_class-properties_private_field_count_is_incorrect_when_class_only_have_accessor_with_private_field
Member
|
I fixed the panic in #10463 and moved this PR to be based on that. |
Member
Author
Merge activity
|
graphite-app
bot
changed the base branch from
04-17-fix_transformer_class-properties_private_field_count_is_incorrect_when_class_only_have_accessor_with_private_field
to
graphite-base/10457
…ount` is 0 at end of transform (#10457) `private_field_count` is incremented when entering a class with private properties/methods and decremented when leaving it. Make sure this is working correctly by ensuring `private_field_count == 0` at the end of the transform. As suggested in #10447 (review).
graphite-app
bot
force-pushed
the
04-16-refactor_transformer_class-properties_debug_assert_private_field_count_is_0_at_end_of_transform
branch
from
51a8979 to
e0ef9a8
Compare
graphite-app
bot
deleted the
04-16-refactor_transformer_class-properties_debug_assert_private_field_count_is_0_at_end_of_transform
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
private_field_countis incremented when entering a class with private properties/methods and decremented when leaving it. Make sure this is working correctly by ensuringprivate_field_count == 0at the end of the transform.As suggested in #10447 (review).